Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

31 removing contract data from admin page #42

Merged
merged 9 commits into from
Apr 10, 2022
Merged

31 removing contract data from admin page #42

merged 9 commits into from
Apr 10, 2022

Conversation

JacobBredin
Copy link
Collaborator

@JacobBredin JacobBredin commented Apr 10, 2022 •
edited
Loading

Summary

Add a remove button for each contract inside the admin page.

image

Definition of done

  • All acceptance criteria are completed.
  • The code has (at least) 80% branch test coverage.
  • All tests pass.
  • The code is reviewed and accepted by (at least) two other team members.
  • Views adhere to design style.

Closes #31

martinjonsson01
martinjonsson01 requested changes Apr 10, 2022
View reviewed changes
Copy link
Owner

@martinjonsson01 martinjonsson01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

The only thing I want you to actually change is the commented out test.
The rest are nit-picks and can be ignored if you choose to.

src/Client/Pages/Admin/ContractListItem.razor Outdated Show resolved Hide resolved
src/Infrastructure/Contracts/FakeContractRepository.cs Show resolved Hide resolved
tests/Application.Tests/Contracts/ContractServiceTests.cs Outdated Show resolved Hide resolved
tests/Presentation.Tests/Client/Pages/Admin/ContractListTests.cs Outdated Show resolved Hide resolved
tests/Presentation.Tests/Server/Controllers/ContractsControllerTests.cs Outdated Show resolved Hide resolved
tests/Presentation.Tests/Server/Controllers/ContractsControllerTests.cs Outdated Show resolved Hide resolved
martinjonsson01
martinjonsson01 approved these changes Apr 10, 2022
View reviewed changes
Copy link
Owner

@martinjonsson01 martinjonsson01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

tests/Application.Tests/Contracts/ContractServiceTests.cs Outdated Show resolved Hide resolved
tests/Application.Tests/Contracts/ContractServiceTests.cs Outdated Show resolved Hide resolved
jonathan-lindqvist
jonathan-lindqvist approved these changes Apr 10, 2022
View reviewed changes
Copy link
Collaborator

@jonathan-lindqvist jonathan-lindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JacobBredin JacobBredin merged commit ad82f3e into master Apr 10, 2022
@martinjonsson01 martinjonsson01 deleted the 31-removing-contract-data-from-admin-page branch April 10, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-lindqvist jonathan-lindqvist jonathan-lindqvist approved these changes

@martinjonsson01 martinjonsson01 martinjonsson01 approved these changes

@Matte02 Matte02 Awaiting requested review from Matte02

@ellsib ellsib Awaiting requested review from ellsib

@Gigset Gigset Awaiting requested review from Gigset

@pkasinski pkasinski Awaiting requested review from pkasinski

@XwayTomy XwayTomy Awaiting requested review from XwayTomy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing contract data from admin page
3 participants
@JacobBredin @martinjonsson01 @jonathan-lindqvist