Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97 editing contract data from admin page #136

Merged
merged 15 commits into from
May 11, 2022

Conversation

martinjonsson01
Copy link
Owner

Summary

Makes contracts editable from the admin page.

The new tabs:
chrome_o7pkdoLdZy

Example of changing a contract name:
chrome_dIPldKbZQ5

Example of changing a contract logo:
chrome_d8EvlbHBc1

Definition of done

  • All acceptance criteria are completed.
  • The code has (at least) 80% branch test coverage.
  • All tests pass.
  • The code is reviewed and accepted by (at least) two other team members.
  • Views adhere to design style.

Closes #97

Copy link
Collaborator

@Matte02 Matte02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have a question about the gifs. It looks like you are pressing way above the actual buttons, i.e in the first gif when swapping between the taps I hope it's just the recording that is messed up and not like that in reality.

@martinjonsson01
Copy link
Owner Author

@Matte02

It looks like you are pressing way above the actual buttons, i.e in the first gif when swapping between the taps I hope it's just the recording that is messed up and not like that in reality.

Yeah, that's just the GIF. I think it's because of my Windows scaling being set to 125%, the recording software doesn't take that into account.

Copy link
Collaborator

@pkasinski pkasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/Client/Pages/Admin/ContractForm.razor Outdated Show resolved Hide resolved
@martinjonsson01 martinjonsson01 merged commit 3e63173 into master May 11, 2022
@martinjonsson01 martinjonsson01 deleted the 97-editing-contract-data-from-admin-page branch May 11, 2022 08:58
@martinjonsson01 martinjonsson01 mentioned this pull request May 13, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QoL: Editing contract data from admin page
3 participants