Fix known issues in the snull driver #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first device registration fails, the second iteration of the loop will set the ret to zero. Also, jumping to snull_cleanup() will put the device into unreg queue which is unnecessary.
By using napi_schedule_prep() and __napi_schedule(), ensure NAPI polls are scheduled before disabling interrupts. This prevents dropped polls and ensures rx_int_enabled is properly updated, fixing 100% packet loss during state changes. Authored-by: Leon <[email protected]> Signed-off-by: Iman Seyed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snull_init_module(void)if the first device registration fails, the second iteration of the loop will set theretto zero. Also, jumping tosnull_cleanup()will put the device intounregqueue which is unnecessary.