-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple silicon & Python 3.12 #20
Conversation
Testing support for Apple Silicon
Testing build on macos
The zip file structure changed. The files are now in a subdirectory.
Support for apple silicon
@@ -12,7 +12,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
os: [macos-latest, ubuntu-latest, windows-latest] | |||
os: [macos-13, ubuntu-latest, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want both: os: [macos-13, macos-14, ubuntu-latest, windows-latest]
macos-13 for building for x86-64 and macos-14 for building with ARM. At least that's how I did it in my CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried macos-14 but for some reason it's not finding zstd.h. It works fine in macos-13 with no other change.
I have CIBW_ARCHS_MACOS: "x86_64 arm64" which seems to be working fine to build both x86-64 and arm64 wheels.
See this test under check wheels. Does it seem ok to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, looks good and seems more reliable and self-explanatory than running on different macos versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, I'm going ahead and publishing v1.6.1 :) Let's hope for the best.
No description provided.