Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple silicon & Python 3.12 #20

Merged
merged 18 commits into from
May 4, 2024
Merged

Apple silicon & Python 3.12 #20

merged 18 commits into from
May 4, 2024

Conversation

martinellimarco
Copy link
Owner

No description provided.

@martinellimarco martinellimarco merged commit efa50c9 into master May 4, 2024
17 of 18 checks passed
@@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
os: [macos-13, ubuntu-latest, windows-latest]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want both: os: [macos-13, macos-14, ubuntu-latest, windows-latest]
macos-13 for building for x86-64 and macos-14 for building with ARM. At least that's how I did it in my CI.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried macos-14 but for some reason it's not finding zstd.h. It works fine in macos-13 with no other change.
I have CIBW_ARCHS_MACOS: "x86_64 arm64" which seems to be working fine to build both x86-64 and arm64 wheels.
See this test under check wheels. Does it seem ok to you?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, looks good and seems more reliable and self-explanatory than running on different macos versions.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I'm going ahead and publishing v1.6.1 :) Let's hope for the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants