use false for requiresMetadata

martijnvg · Oct 23, 2024 · 1a8cb5b · 1a8cb5b
1 parent 4b6d288
commit 1a8cb5b
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/...ql/compute/src/main/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperator.java b/...ql/compute/src/main/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperator.java
@@ -244,9 +244,7 @@ private void loadFromSingleLeaf(Block[] blocks, int shard, int segment, BlockLoa
             SourceLoader sourceLoader = null;
             if (storedFieldsSpec.requiresSource()) {
                 sourceLoader = shardContexts.get(shard).newSourceLoader.get();
-                storedFieldsSpec = storedFieldsSpec.merge(
-                    new StoredFieldsSpec(true, storedFieldsSpec.requiresMetadata(), sourceLoader.requiredStoredFields())
-                );
+                storedFieldsSpec = storedFieldsSpec.merge(new StoredFieldsSpec(true, false, sourceLoader.requiredStoredFields()));
             }
 
             if (rowStrideReaders.isEmpty()) {
@@ -393,9 +391,7 @@ private void fieldsMoved(LeafReaderContext ctx, int shard) throws IOException {
             SourceLoader sourceLoader = null;
             if (storedFieldsSpec.requiresSource()) {
                 sourceLoader = shardContexts.get(shard).newSourceLoader.get();
-                storedFieldsSpec = storedFieldsSpec.merge(
-                    new StoredFieldsSpec(true, storedFieldsSpec.requiresMetadata(), sourceLoader.requiredStoredFields())
-                );
+                storedFieldsSpec = storedFieldsSpec.merge(new StoredFieldsSpec(true, false, sourceLoader.requiredStoredFields()));
             }
             storedFields = new BlockLoaderStoredFieldsFromLeafLoader(
                 StoredFieldLoader.fromSpec(storedFieldsSpec).getLoader(ctx, null),