configure.ac: Fix check for parted #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartialVolume
requested changes
May 6, 2024
There was a problem hiding this comment.
I think , [libconfig] on line 72 can be removed completely as checks for libconfig are performed earlier in the configure.ac file and with , [libconfig] on line 72 removed, configure will correctly abort if the libconfig library or libconfig dev is missing.
Line 72 can be changed from
PKG_CHECK_MODULES([PARTED], [libparted], [libconfig])
to
PKG_CHECK_MODULES([PARTED], [libparted])
PKG_CHECK_MODULES needs all modules in a single list or else the following error message appears during configure run: ./configure: 6807: libconfig: not found because the macro interprets "[libconfig]" as the action that needs to be done if parted was found. Removed superfluous check for libconfig as requested by PartialVolume
Done as requested. |
PartialVolume
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKG_CHECK_MODULES needs all modules in a single list or else the following error message appears during configure run:
./configure: 6807: libconfig: not foundbecause the macro interprets "[libconfig]" as the action that needs to be done if parted was found.