Minor accessibility improvements #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* better color contrasts for links when "contrasted colors is activated) * add some titles on links containing only an icon * add some alt on img * add some aria- attributes on mobile toggle button
delete lock file wrongly introduced in previous commit
martignoni
reviewed
Jan 28, 2022
assets/css/custom.css
Outdated
| @@ -48,6 +48,13 @@ $accessible-gray-column-color: $gray-column-color; | |||
| background-color: $accessible-neutral-color; | |||
| } | |||
|
|
|||
| .accessible-colors .navbar-default .navbar-nav>li>a{ | |||
There was a problem hiding this comment.
The contrast can be enhanced for the non-accessible colors too: suggesting to move this to main.css, without .accessible-colors selector. The color can be more contrasted too, e.g. #“666.
There was a problem hiding this comment.
I agree: I thought that maybe you would not accept to change the main colors, but indeed it will be better that way!
martignoni
reviewed
Jan 28, 2022
| color: #707070; /* Grey */ | ||
| } | ||
|
|
||
| .accessible-colors{ |
There was a problem hiding this comment.
This is a bit of difficulty, as default accent color (#f98012) is a brand color. Anyway, a step in a good direction.
martignoni
requested changes
Jan 28, 2022
Very good tip! Thank you. |
+ gitignore hugo_build.lock
|
Requested change done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
There was some accessibility issues in your website, even when "contrasted colors" was active. this PR will correct it.
detailed changes :
nb : I invite you to install WAVE Browser Extensions https://wave.webaim.org/extension to test in one click you're website accessibility.
Have a nice day ! ;)