Complex Settings

[mrixner]

• I have read the contributing guidelines, and I agree with the Code of Conduct.
• Have you checked that there aren't other open pull requests for the same changes?
• Have you tested that the committed code can be executed without errors?
• This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
  Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

---

This PR adds complex setting support to the settings engine (lists, dictionaries).

Things I'm planning to accomplish:

• Add List Functions
• Add List Tests
• Add Dictionary Functions
• Add Dictionary Tests
• Make Sure Exporting These Settings Works Properly
• Transfer Ignored Updates (Dictionary)
• Code To Automatically Port Old Ignored Updates

I know we discussed using ISerializable but despite extensive searching I was unable to find a way to easily, automatically serialize ISerializable to JSON because apparently C#'s JSON thing doesn't support ISerializable. Therefore, I'm just converting everything to objects, casting them around and letting the JSON library serialize how it wants.

[marticliment]

Yes, this looks good for me.
Perhaps you could (in order to not have a huge file with the entire settings code) mark the settings class as partial, and have List-related and Dictionary-related settings be implemented in their own files. You can find an example on what I mean on src/UniGetUI/Pages/DialogPages/DuialogHelper_*.cs, which are different files that define different parts of the same static class

[mrixner]

Do you want the installation options to continue to not be backed up in the settings? Because if so I should update IgnoredSettings (SettingsPage.xaml.cs:537) to include the installation options. I think probably, since if settings are used to transfer UniGetUI configurations across computers, installation options would be different across computers.

[mrixner]

Actually, unless you would like me to port them, I think I'll just leave the installation options where they are because the current storage method because it's pretty ingrained. But I'd be happy to port them if you want consistency.

[marticliment]

Actually, unless you would like me to port them, I think I'll just leave the installation options where they are because the current storage method because it's pretty ingrained. But I'd be happy to port them if you want consistency.

I'd leave them as they are, as the method use is very customized for the use cases of the settings.

[marticliment]

Do you want the installation options to continue to not be backed up in the settings? Because if so I should update IgnoredSettings (SettingsPage.xaml.cs:537) to include the installation options. I think probably, since if settings are used to transfer UniGetUI configurations across computers, installation options would be different across computers.

I reckon it makes sense that installation options are exported via package bundles, rather than on the settings

[marticliment]

• Transfer Desktop Shortcuts (Requires Allow Desktop Shortcut Deletion #2985 to be merged) (Dictionary)
  (this won't need transferring if I can add it before beta2)

I will merge both of the PRs before beta2, so there will not be any need to migrate any settings.
I reckon it would be a good idea to first merge this PR, so then you can pull main from the "remove desktop icons" PR, what do you think?

[mrixner]

Yeah, sounds good! Thanks.

[mrixner]

Thanks!
Note: you added a ClearList call in the tests, but I explicitly didn't have one there so it would work as a test of making sure an empty list is returned when a setting doesn't exist.

[marticliment]

I did, because if the tests failed and test files remained the tests would fail infinitely

[mrixner]

OK, that's what I figured, just confirming.