Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths to temp dir / winget.exe #2928

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

derula
Copy link
Contributor

@derula derula commented Nov 3, 2024

  • Temp folder isn't always in %localappdata%\Temp
  • User profile path may contain spaces
  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

On my machine, the WinGet reset feature always prints this at the beginning:

The system cannot find the file specified.
The system cannot find the path specified.

The reason is that my TEMP folder is moved to T:\Temp (%tmp% variable is set accordingly) and my user profile path has a space in it.

This should fix both issues, however:

  • I did not compile UniGetUI to test the change properly.
  • Even performing these steps manually, it still doesn't fix WinGet on my machine. To fix it, I have to manually remove and re-add the sources.

- Temp folder isn't always in `%localappdata%\Temp`
- User profile path may contain spaces
@marticliment
Copy link
Owner

Will test and merge in 1/2 weeks

@marticliment marticliment merged commit 454ca50 into marticliment:main Nov 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants