Fix tests for tornado+pytest issue #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multiline assignments, ignores now go on the value expression, not the trailing paren.
This is a workaround which resolves marshmallow-code#941 for now.
sloria
approved these changes
May 21, 2024
|
Thanks @sirosen for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two small fixes to get clean test runs.
I realized that even if tornado releases with the fix from pytest, we won't instantly drop support for older tornado versions. So the workaround suggested by a pytest dev is what I'm applying here.
I setup a base test class which we can tweak appropriately and set
__test__ = Falseto keep pytest from trying to run tests from that class (which fails in other ways).On my way to this, I found I needed a very minor mypy tweak, which is isolated in a separate commit.