Rename to sky branding #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrutko
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Deployment script, line 21 still refers to the old POT DSR address address internal constant MCD_POT = 0x197E90f9FAD81970bA7976f33CbD77088E5D7cf7;, which does not have the SSR interface. We should disable the script from running with this address. Either assert false with message that POT SSR not deployed yet, or at least leave a very clear, screaming TODO that this has to be changed and the script is not to be used in this shape.
Other than that LGTM. No mentions of of Dai or DSR left.
|
Coverage after merging sky-renames into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be done and re-audited because the Sky version of the pot uses
ssrinstead ofdsr. I figured it makes sense to just rename everything anyways.