Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test with a flashloan #5

Merged
merged 6 commits into from
Mar 6, 2024
Merged

test: add test with a flashloan #5

merged 6 commits into from
Mar 6, 2024

Conversation

barrutko
Copy link
Contributor

No description provided.

hexonaut
hexonaut previously approved these changes Feb 15, 2024
Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some comments

test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
test/Integration.t.sol Outdated Show resolved Hide resolved
Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good. One unrelated, but small thing is I want to set the ICapAutomator pragma to pragma solidity >=0.8.0;. I think we can just include it in this PR for simplicity.

Interfaces should always be way more flexible.

test/Integration.t.sol Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 5, 2024

Coverage after merging add-flash-loan-test into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   CapAutomator.sol100%100%100%100%

Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barrutko barrutko merged commit ecb5608 into master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants