Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-231] Build basic sparklend cap automator #1

Merged
merged 63 commits into from
Dec 15, 2023
Merged

[SC-231] Build basic sparklend cap automator #1

merged 63 commits into from
Dec 15, 2023

Conversation

barrutko
Copy link
Contributor

No description provided.

@barrutko barrutko self-assigned this Nov 17, 2023
@linear Linear
Copy link

linear bot commented Nov 17, 2023

SC-231 Build DC-IAM for Supply/Borrow Caps

@barrutko barrutko marked this pull request as ready for review November 28, 2023 18:01
hexonaut
hexonaut requested changes Nov 30, 2023
View reviewed changes
Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over general structure. Direction looks good. I'll do a full review after the requested changes.

src/CapAutomator.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Outdated Show resolved Hide resolved
hexonaut
hexonaut requested changes Dec 11, 2023
View reviewed changes
Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing and good to merge.

test/CapAutomator.t.sol Outdated Show resolved Hide resolved
lucas-manuel
lucas-manuel requested changes Dec 11, 2023
View reviewed changes
src/CapAutomator.sol Outdated Show resolved Hide resolved
test/mocks/MockPool.sol Show resolved Hide resolved
test/mocks/MockPool.sol Show resolved Hide resolved
test/mocks/MockPool.sol Outdated Show resolved Hide resolved
test/mocks/MockPool.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Show resolved Hide resolved
src/CapAutomator.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Outdated Show resolved Hide resolved
src/CapAutomator.sol Show resolved Hide resolved
lucas-manuel
lucas-manuel requested changes Dec 11, 2023
View reviewed changes
src/CapAutomator.sol Show resolved Hide resolved
hexonaut
hexonaut previously approved these changes Dec 12, 2023
View reviewed changes
Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM. Ready to merge.

lucas-manuel
lucas-manuel requested changes Dec 12, 2023
View reviewed changes
test/CapAutomator.t.sol Show resolved Hide resolved
test/mocks/MockPool.sol Outdated Show resolved Hide resolved
test/CapAutomator.t.sol Outdated Show resolved Hide resolved
test/CapAutomator.t.sol Show resolved Hide resolved
test/CapAutomator.t.sol Show resolved Hide resolved
test/CapAutomator.t.sol Show resolved Hide resolved
test/CapAutomator.t.sol Show resolved Hide resolved
test/CapAutomator.t.sol Show resolved Hide resolved
src/interfaces/ICapAutomator.sol Outdated Show resolved Hide resolved
src/interfaces/ICapAutomator.sol Outdated Show resolved Hide resolved
lucas-manuel
lucas-manuel reviewed Dec 12, 2023
View reviewed changes
src/CapAutomator.sol Outdated Show resolved Hide resolved
lucas-manuel
lucas-manuel requested changes Dec 14, 2023
View reviewed changes
test/CapAutomator.t.sol Outdated Show resolved Hide resolved
test/CapAutomator.t.sol Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Coverage after merging SC-231-build-sparklend-cap-automator into master will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   CapAutomator.sol100%100%100%100%

hexonaut
hexonaut approved these changes Dec 14, 2023
View reviewed changes
Copy link

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barrutko barrutko merged commit a6ead79 into master Dec 15, 2023
3 checks passed
@barrutko barrutko deleted the SC-231-build-sparklend-cap-automator branch December 15, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@lucas-manuel lucas-manuel lucas-manuel approved these changes

Assignees

@barrutko barrutko

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrutko @hexonaut @lucas-manuel