Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-184] Use XChainHelpers instead of custom forwarders #6

Merged
merged 9 commits into from
Oct 16, 2023
Merged

[SC-184] Use XChainHelpers instead of custom forwarders #6

merged 9 commits into from
Oct 16, 2023

Conversation

barrutko
Copy link
Contributor

No description provided.

@barrutko barrutko requested review from hexonaut and lucas-manuel and removed request for hexonaut October 10, 2023 14:17
hexonaut
hexonaut requested changes Oct 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
hexonaut
hexonaut previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

lucas-manuel
lucas-manuel reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Midway through review

test/mocks/GnosisReconfigurationPayload.sol Show resolved Hide resolved
test/mocks/PayloadWithEmit.sol Show resolved Hide resolved
test/mocks/ReconfigurationPayload.sol Show resolved Hide resolved
src/executors/ArbitrumBridgeExecutor.sol Show resolved Hide resolved
test/ArbitrumCrosschainTest.t.sol Show resolved Hide resolved
test/ArbitrumCrosschainTest.t.sol Show resolved Hide resolved
test/ArbitrumCrosschainTest.t.sol Show resolved Hide resolved
lucas-manuel
lucas-manuel requested changes Oct 16, 2023
View reviewed changes
test/CrosschainTestBase.sol Outdated Show resolved Hide resolved
test/CrosschainTestBase.sol Show resolved Hide resolved
test/CrosschainTestBase.sol Show resolved Hide resolved
test/GnosisCrosschainTest.t.sol Show resolved Hide resolved
test/GnosisCrosschainTest.t.sol Show resolved Hide resolved
test/OptimismCrosschainTest.t.sol Show resolved Hide resolved
test/OptimismCrosschainTest.t.sol Show resolved Hide resolved
test/CrosschainTestBase.sol Outdated Show resolved Hide resolved
test/CrosschainTestBase.sol Show resolved Hide resolved
test/GnosisCrosschainTest.t.sol Outdated Show resolved Hide resolved
lucas-manuel
lucas-manuel requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mainly just formatting

hexonaut
hexonaut approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barrutko barrutko merged commit 5aee18b into master Oct 16, 2023
@barrutko barrutko deleted the refactor-forwarders branch October 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@lucas-manuel lucas-manuel lucas-manuel approved these changes

Assignees

@barrutko barrutko

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrutko @hexonaut @lucas-manuel