[SC-105] Rewrite tests & remove 'aave-helpers' dependency #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexonaut
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Two minor issues. This is a good first pass translating the previous version. I'd like to do another PR after where the test logic is merged into a single base test contract and the specifics of the domain are dealt with by inheriting contracts. Similar to how this is done: https://github.com/makerdao/dss-bridge/tree/v1/src/tests/domains
Would also like to see the testing expanded to cover more of the features, but I think ordering can be so as to merge the test contracts first then adding more tests after.
Should be fine now. |
hexonaut
requested changes
Sep 20, 2023
hexonaut
requested changes
Sep 21, 2023
hexonaut
previously approved these changes
Sep 21, 2023
barrutko
commented
Sep 25, 2023
barrutko
commented
Sep 25, 2023
barrutko
commented
Sep 25, 2023
lucas-manuel
approved these changes
Sep 25, 2023
hexonaut
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.