Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General bringing repo up to date #12

Merged
merged 2 commits into from
Mar 29, 2024
Merged

General bringing repo up to date #12

merged 2 commits into from
Mar 29, 2024

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Mar 26, 2024

Latest forge-std, xchain-helpers and fixing the CI. Removed some unused imports too. Note zkevm is broken but can fix in another PR.

Ignore the coverage CI for now, this repo needs to be overhauled.

Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@hexonaut
Copy link
Contributor Author

Disabled zkEVM for now.

Copy link

Coverage after merging latest-xchain-helpers into master will be

84.50%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/executors
   ArbitrumBridgeExecutor.sol0%100%0%0%21
   BridgeExecutorBase.sol85.47%62.50%85.71%94.23%147, 153, 160, 210, 225, 284, 286, 291, 310, 344, 352–353, 360, 364, 384–385, 391, 395, 395, 395, 404
   GnosisBridgeExecutor.sol85%50%100%100%128, 137, 146
   L2BridgeExecutor.sol28.57%100%33.33%25%66–67, 72
   ZkEVMBridgeExecutor.sol0%0%0%0%68, 68, 68–69, 69, 69–70, 70, 70–72, 72, 72, 74, 80, 82, 91–92

@hexonaut hexonaut merged commit 665d45b into master Mar 29, 2024
2 of 3 checks passed
@hexonaut hexonaut deleted the latest-xchain-helpers branch March 29, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants