Update contracts to latest deps #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
force-pushed
the
update-apollo-deps
branch
from
e45cd9f
to
12449d9
Compare
piobab
reviewed
Feb 15, 2023
brimigs
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily was to integrate the new vaults and use the new Apollo versions of:
However, this task required to update nearly everything to their latest dependencies. For the most part, it was seamless. Though, there is one sad issue: CosmWasm/cosmwasm#1608. The Error we need is not exposed publicly. Which means we have to use this ugly syntax in lots of places temporarily:
underlying_value .checked_mul_floor(checked_base_max_ltv) .map_err(|_| TempCheckMulFracError {})?A benefit is that we can delete the whole
Mars-Mathpackage now.