Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server api #27

Merged
merged 25 commits into from
Sep 7, 2024
Merged

Add server api #27

merged 25 commits into from
Sep 7, 2024

Conversation

marph91
Copy link
Owner

@marph91 marph91 commented Aug 28, 2024

  • items
    • Basic items, like notes/notebooks/tags -> Implemented in a similar way like the client API.
    • Resources
    • api/items/:id/delta -> Not implemented. Not sure if needed for automation.
    • api/items/:id/children -> Not sure how it works. Skipped for now.
  • batch / batch items -> Not implemented. Single access is sufficient for now -> Server: add batch requests #28
  • api/events -> Not implemented. Seems to be used to trigger a sync event.
  • debug -> Not implemented. Only available in dev env.
  • locks -> b0a7cd1
  • sessions -> Not implemented. Not sure if needed for automation.
  • share users -> Not implemented. Not sure if needed for automation.
  • shares -> Not implemented. Not sure if needed for automation.
  • users -> Partially implemented. Only a function to fetch users and their permissions.
  • encryption -> Not implemented. Too complex. Too much potential for error.
  • parse info.json (GET /api/items/root:/info.json:/content)

Copy link

github-actions bot commented Aug 30, 2024

Unit Test Results

106 tests  +34   103 ✔️ +34   4m 31s ⏱️ + 4m 17s
  21 suites +  8       3 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 7599afc. ± Comparison against base commit 671c8de.

This pull request removes 72 and adds 106 tests. Note that renamed tests count towards both.
test.test_api.Event ‑ test_get_event
test.test_api.Event ‑ test_get_events_by_cursor
test.test_api.Event ‑ test_get_events_empty
test.test_api.Event ‑ test_get_events_valid_properties
test.test_api.Fuzz ‑ test_random_path
test.test_api.Helper ‑ test_is_id_valid
test.test_api.Helper ‑ test_random_id
test.test_api.Miscellaneous ‑ test_same_id_different_type
test.test_api.Note ‑ test_add
test.test_api.Note ‑ test_add_attach_image
…
test.test_client_api.Event ‑ test_get_event
test.test_client_api.Event ‑ test_get_events_by_cursor
test.test_client_api.Event ‑ test_get_events_empty
test.test_client_api.Event ‑ test_get_events_valid_properties
test.test_client_api.Fuzz ‑ test_random_path
test.test_client_api.Helper ‑ test_is_id_valid
test.test_client_api.Helper ‑ test_random_id
test.test_client_api.Miscellaneous ‑ test_same_id_different_type
test.test_client_api.Note ‑ test_add
test.test_client_api.Note ‑ test_add_attach_image
…
This pull request removes 3 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.
test.test_api.Regression ‑ test_add_todo
test.test_api.Regression ‑ test_long_body
test.test_api.Regression ‑ test_set_location
test.test_client_api.Regression ‑ test_add_todo
test.test_client_api.Regression ‑ test_long_body
test.test_client_api.Regression ‑ test_set_location

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.79592% with 55 lines in your changes missing coverage. Please review.

Project coverage is 93.11%. Comparing base (46cd4c7) to head (4246128).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
joppy/server_api.py 84.49% 49 Missing ⚠️
joppy/data_types.py 97.02% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   97.66%   93.11%   -4.56%     
==========================================
  Files           3        4       +1     
  Lines         429      929     +500     
==========================================
+ Hits          419      865     +446     
- Misses         10       64      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marph91 marph91 merged commit 04ba58b into master Sep 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants