Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unicode Emoji support #53

Merged
merged 3 commits into from
Aug 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [Unreleased]

- Remove Unicode Emoji support due to many issues on stable Chrome ([#53](https://github.com/marp-team/marpit/pull/53))

## v0.0.11 - 2018-08-12

- Bugfix: Pass `class` attribute to pseudo section on advanced background ([#48](https://github.com/marp-team/marpit/pull/48))
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
"rimraf": "^2.6.2"
},
"dependencies": {
"emoji-regex": "^7.0.0",
"js-yaml": "^3.12.0",
"lodash.kebabcase": "^4.1.1",
"markdown-it": "^8.4.2",
Expand Down
64 changes: 0 additions & 64 deletions src/markdown/unicode_emoji.js

This file was deleted.

2 changes: 0 additions & 2 deletions src/marpit.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import marpitSlideContainer from './markdown/slide_container'
import marpitStyleAssign from './markdown/style/assign'
import marpitStyleParse from './markdown/style/parse'
import marpitSweep from './markdown/sweep'
import marpitUnicodeEmoji from './markdown/unicode_emoji'

const defaultOptions = {
backgroundSyntax: true,
Expand Down Expand Up @@ -123,7 +122,6 @@ class Marpit {
.use(marpitSlideContainer, this.slideContainers)
.use(marpitContainerPlugin, this.containers)
.use(marpitParseImage, { filters })
.use(marpitUnicodeEmoji)
.use(marpitSweep)
.use(marpitInlineSVG, this)
.use(marpitStyleAssign, this)
Expand Down
4 changes: 0 additions & 4 deletions src/postcss/printable.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ const plugin = postcss.plugin('marpit-postcss-printable', opts => css =>
height: 100vh;
width: 100vw;
}

[data-marpit-emoji] {
filter: invert(0);
}
}
`.trim()
)
Expand Down
17 changes: 0 additions & 17 deletions src/theme/scaffold.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,6 @@
/** @module */
import Theme from '../theme'

const emojiFonts = [
'Apple Color Emoji',
'Segoe UI Emoji',
'Noto Color Emoji',
'Segoe UI Symbol',
'Android Emoji',
'Twitter Color Emoji',
'EmojiOne Color',
'Symbola',
'EmojiSymbols',
]

const css = `
section {
width: 1280px;
Expand All @@ -38,10 +26,6 @@ section:not([data-marpit-pagination])::after {
display: none;
}

[data-marpit-emoji] {
font-family: ${emojiFonts.map(f => `'${f}'`).join(',')};
}

/* Normalization */
h1 {
font-size: 2em;
Expand All @@ -54,7 +38,6 @@ h1 {
*
* - Define the default slide size.
* - Set default style for `<section>`.
* - Set unicode emoji style for using system emoji fonts.
* - Normalize `<h1>` heading style.
*
* @alias module:theme/scaffold
Expand Down
70 changes: 0 additions & 70 deletions test/markdown/unicode_emoji.js

This file was deleted.

4 changes: 0 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1352,10 +1352,6 @@ electron-to-chromium@^1.3.47:
version "1.3.55"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.55.tgz#f150e10b20b77d9d41afcca312efe0c3b1a7fdce"

emoji-regex@^7.0.0:
version "7.0.0"
resolved "https://registry.yarnpkg.com/emoji-regex/-/emoji-regex-7.0.0.tgz#7c25d9bb46480f9a5a80ab6a2a12935bdde6cb6c"

entities@^1.1.1, entities@~1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/entities/-/entities-1.1.1.tgz#6e5c2d0a5621b5dadaecef80b90edfb5cd7772f0"
Expand Down