-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paginate: skip
directive
#359
Conversation
Thank you for your contribution and making me remind the issue #218. In the original proposal, Your implementation of In any case, I think
I'm not a native speaker, so please let me know if my choice of words was unnatural. Another idea: YAML objectAn another idea is allowing YAML object for setting detailed option for paginate:
show: false
increment: false It's clear intentions for each field of YAML object. However, this may result in more lines of Markdown by directives. I think taking shorter words will be appreciated by Marp users. |
Oh yeah right I did mess up the meaning of
My use case is "animations", I have a series of images which change slightly from one to the next (one image per slide; figures which each highlight a different part of a plot) and would like to have the same page number for all of these. Are you otherwise happy with the PR? 😅 |
changes `hide-and-skip` to `skip` changes `skip` to `hold` updates the documentation regarding pagination
This can already be done with |
This doesn't work for outputting pdfs as fragments get collapsed to the "fully revealed" state (which depending on the specific use case is what is wanted). Additionally there is a small annoyance with fragments: Mixing normal list entries and fragment list entries results in multiple - Bullet point A
- Bullet point B
+ Bullet point C
- Bullet point C.1
+ Bullet point D generates two lists, one for A and B, and one for C, C.1 and D (when fully revealed) The issue with that is that themes need to accommodate this and remove/collapse the margin for subsequent lists It would be great if this could be done "manually" using multiple slides without increasing the page number and total page count |
Here is a workaround for that if you didn't know (from marp-team/marp-cli#496). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI error has been fixed in #360. For running unit tests, could you merge the changes in the upstream branch main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, Thank you for your patient contributions 😄
Ship with the latest v2 release, and let's include it into the downstream Marp projects.
This feature has been proposed and added to the roadmap here but not implemented as of yet.
As I stumbled across this and couldn't replicate it using custom directives I went ahead and tried to implement it myself.
In addition to
paginate: skip
I also addedpaginate: hide-and-skip
which is a combination ofpaginate: false
andpaginate: skip
, thus allowing you to do the following:paginate: true
)paginate: false
)pagination: skip
)pagination: hide-and-skip
)The addition of
hide-and-skip
wasn't part of the original proposal, I therefore split it up into a separate commit which can easily be deleted if the feature isn't wanted.I added 2 tests and updated the docs already, the wording might still need some improvements however.
I'm open for feedback!