fix : utcToZonedTime returns next day when time matches offset #43
Conversation
| }); | ||
|
|
||
| var testDateTimeFormatted = testDateTime.format(new Date("2014-06-25T04:00:00.123Z")) | ||
| if(testDateTimeFormatted === '06/25/2014, 00:00:00' || testDateTimeFormatted === '06/25/2014 00:00:00') { |
There was a problem hiding this comment.
@hyyan it doesn't show here, but in my IDE I see strange characters before and after each part of the second date string you are comparing with. What character is this, and is it there intentionally?
I'm also curious why it is possible to have formatted output either with or without the comma? I would have expected only one possibility for a given locale.
There was a problem hiding this comment.
I noticed when using the timezone polyfill for IE11, the date gets formatted without a comma, that's why I added the check, the string which contains hidden characters is copied directly from IE11 console
| var testDateTimeFormatted = testDateTime.format(new Date("2014-06-25T04:00:00.123Z")) | ||
| if(testDateTimeFormatted === '06/25/2014, 00:00:00' || testDateTimeFormatted === '06/25/2014 00:00:00') { | ||
| dtfCache[timeZone] = new Intl.DateTimeFormat('en-US', { | ||
| hour12: false, |
There was a problem hiding this comment.
Do you know whether IE / Chrome <73 throws an error or warning when hourCycle: undefined is included? It would be nice to collapse this into a single object. hour12 can be specified next to hourCycle, so we could have:
hour12: false,
hourCycle: ... ? "h23" : undefined,
...If you haven't looked at that and don't have the setup to test this easily I will merge it as is though.
There was a problem hiding this comment.
I did not really test it, but most likely it will do
fix #38 , fix #41