use url instead of path #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll review this shortly. |
|
Could you please explain more clearly why you are making these changes? |
marnen
reviewed
Jan 3, 2017
| @@ -21,7 +21,7 @@ def initialize(app, options_hash = {}, &block) | |||
| def breadcrumbs(page, separator: @separator, wrapper: @wrapper) | |||
| hierarchy = [page] | |||
| hierarchy.unshift hierarchy.first.parent while hierarchy.first.parent | |||
| hierarchy.collect {|page| wrap link_to(page.data.title, "/#{page.path}"), wrapper: wrapper }.join(h separator) | |||
| hierarchy.collect { |x| wrap link_to(x.data.title, x.url), wrapper: wrapper }.join(h separator) | |||
There was a problem hiding this comment.
Why are you changing the name of the block argument from page to x?
There was a problem hiding this comment.
Probably because page shadows the first page declared in the signature of the method. Let's call it p instead of x maybe?
There was a problem hiding this comment.
To keep using the path instead of switching to the URL I'd do something like URI(page.url).path or URI(x.url).path. If that's alright I'll do a new pull request with an explanation of where the old way fails for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url handles clean url properly.
We should use url instead of path to be work with
activate :directory_indexes.