Use Resource#url to honour directory indexes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource#path does not work well with Middleman Pretty URLs, see https://middlemanapp.com/advanced/pretty_urls Using Resource#url fixes the problem as it follows the app configs.
assimovt
pushed a commit
to Dockbit/docs
that referenced
this pull request
Sep 4, 2016
Until marnen/middleman-breadcrumbs#12 is merged used this custom fork to fix the pretty-url links in breadcrumbs
|
#9 might be related to this. |
|
Resource#url seems to be handling it already. |
|
This will need tests before I can merge it. Also, what is the problem with |
|
Hmm...I see that this has tests, which I somehow missed last time I looked. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource#path does not work well with Middleman Pretty URLs,
see https://middlemanapp.com/advanced/pretty_urls
Using Resource#url fixes the problem as it follows the app configs.