Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Fix useGetManyReference return type #9963

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jun 28, 2024

The discriminated union of the return type by state doesn't work for this hook because of Omit. This Omit is an error and shouldn't be here. Removing it solves the problem.

Before After
image image

This problem was introduced in dc19387

The discriminated union of the return type by state doesn't work for this hook because of `Omit`. This `Omit` is an error and shouldn't be here. Removing it solves the problem.
@djhi djhi added this to the 5.0.3 milestone Jun 28, 2024
@djhi djhi merged commit 1d117a9 into master Jun 28, 2024
14 checks passed
@djhi djhi deleted the fix-useGetManyReference-return-type branch June 28, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants