<ArrayInput> uses SourceContext instead of cloning children
#9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jun 10, 2024
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Jun 11, 2024
packages/ra-ui-materialui/src/field/TranslatableFieldsTabContent.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/field/TranslatableFieldsTabContent.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/field/TranslatableFieldsTabContent.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Jun 11, 2024
packages/ra-ui-materialui/src/field/TranslatableFieldsTabContent.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIteratorItem.tsx
Show resolved
Hide resolved
fzaninotto
requested changes
Jun 12, 2024
packages/ra-ui-materialui/src/input/ArrayInput/ArrayInput.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/ArrayInput.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/field/TranslatableFieldsTabContent.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
approved these changes
Jun 12, 2024
fzaninotto
deleted the
use-source-prefix-context-in-array-input-and-simple-form-iterator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
<ArrayInput>and<SimpleFormIterator>are still cloning their children. Besides,<SimpleFormIterator>throws an Error when used without a source prop.Solution
Migrate both components to support the
SourceContextand no longer require cloning their children.This is a BC so this needs to be done before the v5 release.