Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filters with complex object are not removed from the UI #9898

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix filters with complex object are not removed from the UI #9898

merged 3 commits into from
Jun 11, 2024

Commits on Jun 4, 2024

  1. fix: Filters visibility after user clicks "Remove filter" button 

    When filters with a complex object as defaultValue
the "empty value" was not considered empty by the UI.
This commit ensure we don't display empty filters on the
UI.

Refs: marmelab#9893
    @hmatthieu
    hmatthieu committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0658077 View commit details
    Browse the repository at this point in the history

  2. fix: Filters visibility after user clicks "Remove filter" button 

    Add test to ensure correction.

Refs: marmelab#9893
    @hmatthieu
    hmatthieu committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7f25557 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. fix: Adds an exists condition to cypress test to ensure app is ready 

    Refs: marmelab#9893
    @hmatthieu
    hmatthieu committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d8e38cb View commit details
    Browse the repository at this point in the history