Fix useAuthProvider may return undefined when no authProvider is available
#9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
May 21, 2024
| }, | ||
| [resetStore, location, navigate, loginUrl, queryClient] | ||
| [authProvider, resetStore, loginUrl, queryClient, location, navigate] |
There was a problem hiding this comment.
This is problematic: location changes on every navigation, so the callback memoization is weak. You're using a locationRef for the sarch and hash, why not for the pathName?
There was a problem hiding this comment.
I don't know why it was not done for pathName (I just moved the content of the second useCallback). But I assume we probably simply forgot to change this second callback to use refs while we changed the first callback, 2 years ago. Besides I can't think of any negative consequences this might have, so I used refs in this second part, too.
Nice catch!
| timer = setTimeout(() => { | ||
| timer = undefined; | ||
| }, 0); | ||
| ? authProvider |
There was a problem hiding this comment.
I think this method is a bit too long for a legible ternary. I'd prefer a leave early.
fzaninotto
approved these changes
May 21, 2024
adguernier
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BC introduced by #9760 (comment)