Fix strictNullCheck errors in examples #9833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
changed the title
fzaninotto
requested changes
May 6, 2024
| @@ -113,7 +113,7 @@ const PostCreate = () => { | |||
| <FileInput | |||
| source="pdffile" | |||
| label="PDF-Template" | |||
| accept="application/pdf" | |||
| accept={{ 'application/pdf': ['.pdf'] }} | |||
There was a problem hiding this comment.
Shouldn't we update the doc, too?
|
I think we should add the typescheck of the simple example to the typecheck CI step |
Added |
fzaninotto
reviewed
May 6, 2024
| @@ -72,7 +72,7 @@ Files are accepted or rejected based on the `accept`, `multiple`, `minSize` and | |||
| Equivalent of [the `accept` attribute of an `<input type="file">`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#accept). `accept` must be a valid [MIME type](https://www.iana.org/assignments/media-types/media-types.xhtml), according to [input element specification](https://www.w3.org/wiki/HTML/Elements/input/file) or a valid file extension. | |||
|
|
|||
| ```jsx | |||
| <FileInput source="attachments" accept="application/pdf"> | |||
| <FileInput source="attachments" accept={{ 'application/pdf': ['.pdf'] }}> | |||
There was a problem hiding this comment.
Can you also add a mention about this change in the Upgrade guide?
fzaninotto
reviewed
May 6, 2024
.github/workflows/test.yml
Outdated
| with: | ||
| install-command: yarn --immutable | ||
| - name: Build | ||
| run: make build |
There was a problem hiding this comment.
Why do you need to build here? It shouldn't be necessary
fzaninotto
reviewed
May 6, 2024
.github/workflows/test.yml
Outdated
| @@ -67,6 +67,27 @@ jobs: | |||
| env: | |||
| CI: true | |||
|
|
|||
| simple-example: | |||
There was a problem hiding this comment.
Can't you just add a step in the typecheck workflow?
djhi
force-pushed
the
simple-example-strictNullCheck
branch
from
f921c56
to
b0e1b62
Compare
fzaninotto
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.