[Dev] Speed up unit tests by not using MUI Icons barrel files #9828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the advice at https://mui.com/material-ui/guides/minimizing-bundle-size/#development-environment, I fixed the few imports from `@mui/material-icons` and replaced them with named imports for individual icons. The results are spectacular. The `npx jest` command now takes a fraction of the time. On my laptop: * Before: 118s * After: 41s
djhi
approved these changes
May 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the advice at https://mui.com/material-ui/guides/minimizing-bundle-size/#development-environment, I fixed the few named imports from
@mui/material-iconsand replaced them with default imports for individual icons.The results are spectacular. The
npx jestcommand now takes a fraction of the time.On my laptop:
On the CI: