<DatagridBody> creates the <RecordContext> instead of <DatagridRow>
#9808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
May 2, 2024
Done, I pushed in a hurry |
fzaninotto
requested changes
May 2, 2024
…text-instead-of-datagrid-row
fzaninotto
requested changes
May 7, 2024
erwanMarmelab
approved these changes
May 10, 2024
fzaninotto
requested changes
May 13, 2024
docs/Upgrade.md
Outdated
Comment on lines
772
to
791
| + {data.map((record, rowIndex) => ( | ||
| + <RecordContextProvider | ||
| + value={record} | ||
| + key={record.id ?? `row${rowIndex}`} | ||
| + > | ||
| + {cloneElement( | ||
| row, | ||
| { | ||
| //... | ||
| id: record.id ?? `row${rowIndex}`, | ||
| - key: record.id ?? `row${rowIndex}`, | ||
| onToggleItem, | ||
| - record, | ||
| resource, | ||
| //... | ||
| }, | ||
| children | ||
| - ) | ||
| )} | ||
| + </RecordContextProvider> |
There was a problem hiding this comment.
wrong diff: you should show how a custom DatagridRow no longer reads the record from its props, but from the Recordcontext.
erwanMarmelab
approved these changes
May 13, 2024
djhi
reviewed
May 13, 2024
djhi
approved these changes
May 13, 2024
djhi
deleted the
datagrid-body-oss-should-create-a-record-context-instead-of-datagrid-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to delegate the creation of a
<RecordContext>to<DatagridBody>instead of<DatagridRow>