-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetchJSON
adds useless Content-Type header for empty requests
#9613
Merged
fzaninotto
merged 5 commits into
marmelab:master
from
chrisDeFouRire:fix-empty-body-fetch
Jan 25, 2024
Merged
Fix fetchJSON
adds useless Content-Type header for empty requests
#9613
fzaninotto
merged 5 commits into
marmelab:master
from
chrisDeFouRire:fix-empty-body-fetch
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisDeFouRire
changed the title
Sending json Content-Type header for empty body breaks some parsers
Sending json Content-Type header with an empty body breaks some parsers
Jan 25, 2024
fzaninotto
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
fzaninotto
approved these changes
Jan 25, 2024
Thank you for giving us React Admin! it's a great tool ! and seeing how easily I can contribute makes me think it's the perfect tool for us even more! 🙏🙏 |
fzaninotto
changed the title
Sending json Content-Type header with an empty body breaks some parsers
Fix Jan 25, 2024
fetchJSON
adds useless Content-Type header for empty requests
Thanks for your PR, and for your kind words! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Fastify on the backend, and it refuses
DELETE
requests sent from react-admin'sra-data-json-server
.It is because
fetchUtils.fetchJson
is setting theContent-Type
header toapplication/json
, even with an empty body like in the delete requests. The function that is setting the header iscreateHeadersFromOptions
infetch.ts
.It is not against the RFCs to do so, but it just breaks Fastify, and it makes little sense to send a Content-Type with a body that doesn't adhere to the content type: an empty body isn't valid json.
This pull request fixes the issue and adds new unit tests to ensure there is no regression.
yarn test-unit -- ./packages/ra-core/src/dataProvider/fetch.spec.ts
passes.I guess the alternatives are:
'null'
in it)ra-data-json-server
package (and other data providers which are using DELETE with no body) to specify a body.I thought fixing the
createHeadersFromOptions
option was the cleanest