Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix link to documentation root #9602

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[Doc] Fix link to documentation root #9602

merged 1 commit into from
Jan 23, 2024

Conversation

fzaninotto
Copy link
Member

The page https://marmelab.com/react-admin/Readme.html is no longer maintained an isn't the documentation root anymore. Yet it is visited by users who find links elsewhere in the documentation.

We can't remove this page though, as existing installations of react-admin will still point to it in the Error page.

@djhi djhi merged commit 71aaf60 into master Jan 23, 2024
11 checks passed
@djhi djhi deleted the doc-fix-link-readme branch January 23, 2024 12:47
@djhi djhi added this to the 4.16.8 milestone Jan 23, 2024
var href = [
...locationSlices.slice(0, locationSlices.length - 2),
version,
'navigation.html',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you chose 'navigation.html' here an not 'documentation.html'. Is it intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's a mistake!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 6df8224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants