Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix jekyll trying to parse jsx code on <Edit mutationOptions> example snippet #9573

Merged

Conversation

Szulerinio
Copy link
Contributor

I didn't run this locally, but my research points to me that this should fix the issue of
<Edit mutationOptions={{ onSuccess }} mutationMode="pessimistic">
being displayed as
<Edit mutationOptions= mutationMode="pessimistic">

image

@Szulerinio Szulerinio changed the title [Doc] fix jekyll trying to parse jsx code [Doc] fix jekyll trying to parse jsx code on <Edit> mutationOptions Jan 10, 2024
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@adguernier adguernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
But why targeting the “next” branch since this branch is reserved for new features? Can you target the master branch? 🙏

@Szulerinio Szulerinio changed the base branch from next to master January 11, 2024 08:19
@Szulerinio
Copy link
Contributor Author

I guess i should close this PR and make one based on master branch
am I correct?

@fzaninotto
Copy link
Member

yes, GitHub somehow messed up your rebase.

@slax57 slax57 force-pushed the doc]-fix-jekyll-trying-to-parse-jsx-code branch from 0bd8299 to 9910dc1 Compare January 12, 2024 14:28
@slax57 slax57 merged commit 785dc9e into marmelab:master Jan 12, 2024
0 of 2 checks passed
@slax57 slax57 added this to the 4.16.6 milestone Jan 12, 2024
@slax57 slax57 changed the title [Doc] fix jekyll trying to parse jsx code on <Edit> mutationOptions [Doc] Fix jekyll trying to parse jsx code on <Edit mutationOptions> example snippet Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants