Fix update button cannot be used in a list #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Oct 26, 2023
packages/ra-ui-materialui/src/button/UpdateWithUndoButton.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/button/UpdateWithUndoButton.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/button/UpdateWithUndoButton.spec.tsx
Outdated
Show resolved
Hide resolved
adguernier
reviewed
Oct 26, 2023
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
fzaninotto
requested changes
Oct 26, 2023
fzaninotto
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
UpdateButton cannot be used in a List because it does not allow to stop the propagation of the click event, hence it redirects to the Edit view. We should add a way to prevent this.
Solution
Stop the propagation and add test and story