Fix ra-data-graphql-simple creates incorrect query when schema contains a non-null list #9371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle nested lists and non-null types.
slax57
requested changes
Oct 23, 2023
Sure, thanks for the notice. Removed them. |
slax57
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9370, since I couldn't provide a sandbox environment due to GraphQL endpoint requirement. Unit tests should help illustrate the case.
Nullability and lists can be nested, which was incorrectly handled previously. A scenario:
IDra-data-graphql-simplegenerates:[ID!](item is non-nullable, while list is nullable), however it should be[ID!]!Moved logic to a new file and added additional unit tests.