Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useGetList optimistic cache update leads to ui freeze when too many records are returned #9359

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix useGetList optimistic cache update leads to ui freeze when too many records are returned #9359

merged 2 commits into from
Oct 16, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Oct 13, 2023

Solution: only pre-populate the getOne query cache when there is a reasonable number of records returned, say 100.

@slax57 slax57 added the RFR Ready For Review label Oct 13, 2023
fzaninotto
fzaninotto requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/ra-core/src/dataProvider/useGetList.ts Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 39e2bef into master Oct 16, 2023
2 checks passed
@fzaninotto fzaninotto deleted the fix-useGetList-big-data-cache-update branch October 16, 2023 09:43
@fzaninotto fzaninotto added this to the 4.15.1 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchaffotte mchaffotte mchaffotte approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@slax57 @fzaninotto @mchaffotte