Fix DatagridConfigurable editor allows to drag fields outside its list #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchaffotte
approved these changes
Oct 12, 2023
slax57
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Seems mostly OK, but I ran across I weird issue.
If you still drop the item below the buttons, then visually the item is moved to the latest position in the list, but the column is actually not moved in the Datagrid.
Capture.video.2023-10-12.10.49.05.mp4
And it you repeat that multiple times, then afterwards the component is completely broken and columns no longer match the order of the inspector.
djhi
commented
Oct 12, 2023
slax57
deleted the
fix-datagrid-configurable-fields-selector-drag-drop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When configuring the
DatagridConfigurableusing its editor, one can drag and drop a field outside the list of fields (for instance below the button)Solution
Wrap the items list in a
ulelement and double check users drop the column inside it