[Doc] Add i18n InputHelpterText section to Inputs/useInputs docs #9315
Conversation
|
|
||
| **Reminder:** [react-hook-form's `formState` is wrapped with a Proxy](https://react-hook-form.com/docs/useformstate/#rules) to improve render performance and skip extra computation if specific state is not subscribed. So, make sure you deconstruct or read the `formState` before render in order to enable the subscription. | ||
|
|
||
| ```js | ||
| const { isDirty } = useFormState(); // ✅ | ||
| const formState = useFormState(); // ❌ should deconstruct the formState | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I believe we should keep this one. @fzaninotto?
There was a problem hiding this comment.
It's true that the reminder is mentioned twice in this chapter. I'd create a dedicated section explaining how to read the form state, and removing the reminder from the two sections avout TextField and Select.
There was a problem hiding this comment.
@djhi Do you want to do it or should I? Rock paper scissors?
There was a problem hiding this comment.
🪨 That's not really related to your PR so if you don't, we'll open a new PR for that.
There was a problem hiding this comment.
I'm on it then, after all, I broached it by removing the repeated section.
|
This seems to have turned into a real mess, probably because one of my local branches inadvertently targeted 'next' (?). If it's not easy enough to unspool on your end, let me know and I'll start over and copy my changes to a new PR. |
slax57
force-pushed
the
add-helptertext-section-to-inputs
branch
from
ad6f8b1
to
b8baede
Compare
|
@ZachSelindh I've fixed it for you. Should be good now. |
|
Thanks! |
slax57
changed the title
This PR adds an i18n section to the Inputs.md doc instructing users on the use of the
InputHelperTextcomponent.A tip referencing the use of said component has also been added to useInput.md.
I also removed a redundant
formStatereminder from useInput.mdThanks!