Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix external link in <FileInput> and <ImageInput> #9268

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Sep 12, 2023

No description provided.

@@ -44,7 +44,7 @@ The input value must be an object or an array of objects with a `title` and a `s
After modification by the user, the value is stored as an array of objects with 3 properties:

* `title`: the file name with extension, e.g. 'Invoice-2929-01-06.pdf',
* `src`: An [object URL](https://developer.mozilla.org/fr/docs/Web/API/URL/createObjectURL) for the `File`, e.g. 'blob:https://example.com/1e67e00e-860d-40a5-89ae-6ab0cbee6273'
* `src`: An [object URL](https://developer.mozilla.org/en/docs/Web/API/URL/createObjectURL) for the `File`, e.g. 'blob:https://example.com/1e67e00e-860d-40a5-89ae-6ab0cbee6273'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking on this new link, this uri is redirected to https://developer.mozilla.org/en/docs/Web/API/URL/createObjectURL) so is it better to change by en-US directly?

@@ -42,7 +42,7 @@ The input value must be an object or an array of objects with a `title` and a `s
After modification by the user, the value is stored as an array of objects with 3 properties:

* `title`: the file name with extension, e.g. 'Invoice-2929-01-06.pdf',
* `src`: An [object URL](https://developer.mozilla.org/fr/docs/Web/API/URL/createObjectURL) for the `File`, e.g. 'blob:https://example.com/1e67e00e-860d-40a5-89ae-6ab0cbee6273'
* `src`: An [object URL](https://developer.mozilla.org/en/docs/Web/API/URL/createObjectURL) for the `File`, e.g. 'blob:https://example.com/1e67e00e-860d-40a5-89ae-6ab0cbee6273'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

@fzaninotto fzaninotto merged commit bc81f0c into marmelab:master Sep 12, 2023
2 checks passed
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.14.1 milestone Sep 12, 2023
@fzaninotto fzaninotto changed the title [Doc] Fix english uri reference [Doc] Fix external link in <FileInput> and <ImageInput> Sep 12, 2023
@WiXSL WiXSL deleted the fix-doc-en branch September 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants