Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AutocompleteInput's onInputChange is never called #9240

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix AutocompleteInput's onInputChange is never called #9240

merged 2 commits into from
Sep 1, 2023

Conversation

tdnl
Copy link
Contributor

@tdnl tdnl commented Sep 1, 2023

Closes #9239

@tdnl tdnl force-pushed the fix-autocomplete-oninputchange branch from f284804 to c4de05c Compare September 1, 2023 15:15
@tdnl tdnl changed the title fix AutocompleteInput onInputChange is never called fix AutocompleteInput's onInputChange is never called Sep 1, 2023
djhi
djhi approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 4.13.4 milestone Sep 1, 2023
@djhi djhi merged commit 21c4eaf into marmelab:master Sep 1, 2023
7 checks passed
@tdnl tdnl deleted the fix-autocomplete-oninputchange branch September 1, 2023 15:40
@djhi
Copy link
Collaborator

djhi commented Sep 5, 2023

Hey @TNDL, I've merged a little fast actually. First, we're missing documentation about this prop. Second, it appears there's an issue with this implementation: an effect is ran after the custom onInputChange is called and it will be called again with the previous value.
Can you please make a new PR with a story for this prop and adding documentation?

@tdnl
Copy link
Contributor Author

tdnl commented Sep 5, 2023 •
edited
Loading

Hey @djhi, got it, looking into it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.13.4
Development

Successfully merging this pull request may close these issues.

AutocompleteInput's onInputChange prop is never called
2 participants
@tdnl @djhi