-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update <PrevNextButtons>
to fetch less aggressively
#9209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Aug 21, 2023
// If the previous and next ids are not in the cache, fetch the entire list. | ||
// This is necessary e.g. when coming directly to a detail page, | ||
// without displaying the list first | ||
const { data, error, isLoading } = useQuery( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used useQuery instead of useGetList to avoid paying the tax of prepopulating the getOne
cache, which can be costly for large lists.
adguernier
reviewed
Aug 22, 2023
adguernier
approved these changes
Aug 22, 2023
slax57
requested changes
Aug 23, 2023
slax57
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
<PrevNextButtons>
has to fetch the entire list to determine the previous and next id. This may be costly in network and server time (on the client-side, iven with a list of 1000 items, the time is negligible).Solution
Check if the previous and next id can't be determined from the cache first, so that users coming from a list page don't need to fetch the entire list of records
Out of scope
When a user reaches the end of the list cache, update the list params in the store to increment or decrement the page.
To Do
<PrevNextButtons />
in the demofilterDefaultValues