Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.json should mention peer dependency on react-is #9201

Merged
merged 4 commits into from
Aug 22, 2023

Commits on Aug 21, 2023

  1. Update package.json

    https://github.com/marmelab/react-admin/blob/83dc1d61f0d7efaafebb57885d6b55f78509b581/packages/ra-ui-materialui/src/form/FormTabHeader.tsx has an import from `react-is`, but it is not declared in `package.json`
    
    This was causing errors in my rollup build. I cannot be sure this is the right fix - for my project, I had to add this in my `.yarmrc.yml`:
    
    ```
    packageExtensions:
      "ra-ui-materialui@*":
        dependencies:
          "react-is": "*"
    ```
    Here, `peerDependencies` doesn't work, but for `package.json` I think it makes sense to put it there.
    kamiyo authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6d83df5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Update yarn.lock

    kamiyo authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    11665f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    161086f View commit details
    Browse the repository at this point in the history
  3. fix yarn.lock

    slax57 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1caab47 View commit details
    Browse the repository at this point in the history