Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo] Improve CRM Demo Kanban code #9114

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Demo] Improve CRM Demo Kanban code #9114

merged 1 commit into from
Jul 20, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Jul 20, 2023

  • Improve code readability by removing useless variables and renaming
  • extract the update logic to dedicated functions
  • fix index computation logic for some corner cases (while persisting the changes)

Changes inspired by the work on https://github.com/marmelab/ra-example-kanban and the (upcoming) related blog post.

@slax57 slax57 added the RFR Ready For Review label Jul 20, 2023
djhi
djhi approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi added this to the 4.12.2 milestone Jul 20, 2023
@djhi djhi merged commit af66691 into master Jul 20, 2023
@djhi djhi deleted the improve-crm-demo-kanban branch July 20, 2023 14:38
@quentin-decre
Copy link
Contributor

Great ! Thanks I will have a look.
Do you think PostColumn could use InfiniteList to render it's content ? Will all side-to-side infinite lists load next page when I scroll to the bottom of the body ?

@djhi
Copy link
Collaborator

djhi commented Jul 21, 2023

Great ! Thanks I will have a look. Do you think PostColumn could use InfiniteList to render it's content ? Will all side-to-side infinite lists load next page when I scroll to the bottom of the body ?

Probably tricky as each column has its own scroll container.

@quentin-decre
Copy link
Contributor

:'(
How should we do that ?

@djhi
Copy link
Collaborator

djhi commented Jul 21, 2023

I have no idea, yet. Could be a nice challenge for a hackday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@slax57 @quentin-decre @djhi