feat: unix boolean prop for DateField
#9061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! As it's a new feature, please rebase your PR against the |
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
…`<ReferenceInput>`
…tion into account
`record` is guaranteed to not be `undefined`, as there’s a falsey check on line 30. It also must return a viable ReactNode that can be rendered.
Matches changes implemented in marmelab#8964
Cast field.value passed to checked prop in boolean, to avoid checked prop to be <empty string> in BooleanInput
TurtIeSocks
force-pushed
the
unix-date-detection
branch
from
519a340
to
144ba09
Compare
|
I don't get this. It seems to me it already works. In this sandbox (https://stackblitz.com/edit/github-v5fmzn?file=src%2Fdata.tsx), I changed the dates in the |
|
This is already working since react-admin 4.11 (see #8863) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
unixboolean prop to theDateFieldcomponent that will multiple a field value by 1000, assuming it is a number.