Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <CheckForApplicationUpdate> to suggest a reload when the application code has changed #9059

Merged
merged 21 commits into from
Aug 10, 2023
Merged

Add <CheckForApplicationUpdate> to suggest a reload when the application code has changed #9059

merged 21 commits into from
Aug 10, 2023

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jun 28, 2023 •
edited
Loading

  • Implementation
  • Documentation

image

@djhi djhi added the WIP Work In Progress label Jun 28, 2023
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Jul 4, 2023
adguernier
adguernier reviewed Jul 5, 2023
View reviewed changes
docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/useCheckForApplicationUpdate.md Outdated Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
slax57
slax57 requested changes Jul 5, 2023
View reviewed changes
docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/useCheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/useCheckForApplicationUpdate.md Outdated Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/ApplicationUpdatedNotification.tsx Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/ApplicationUpdatedNotification.tsx Show resolved Hide resolved
fzaninotto
fzaninotto requested changes Jul 5, 2023
View reviewed changes
docs/CheckForApplicationUpdate.md Show resolved Hide resolved
docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/CheckForApplicationUpdate.md

## Usage

Include this component in a custom layout:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do it by default in create-react-admin.

docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
docs/CheckForApplicationUpdate.md Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/CheckForApplicationUpdate.tsx Outdated Show resolved Hide resolved
docs/img/CheckForApplicationUpdate.png Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 782386d into next Aug 10, 2023
8 checks passed
@fzaninotto fzaninotto deleted the code-has-changed branch August 10, 2023 14:17
@fzaninotto fzaninotto added this to the 4.13.0 milestone Aug 10, 2023
@fzaninotto fzaninotto changed the title Introduce CheckForApplicationUpdate Add <CheckForApplicationUpdate> to suggest a reload when the application code has changed Aug 14, 2023
@bicstone bicstone mentioned this pull request Aug 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

@adguernier adguernier adguernier approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@djhi @fzaninotto @adguernier @slax57