[Doc] Document useRegisterMutationMiddleware #9031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jun 20, 2023
fzaninotto
approved these changes
Jun 22, 2023
slax57
requested changes
Jun 22, 2023
| @@ -119,6 +119,7 @@ | |||
| <li {% if page.path == 'useEditContext.md' %} class="active" {% endif %}><a class="nav-link" href="./useEditContext.html"><code>useEditContext</code></a></li> | |||
| <li {% if page.path == 'useEditController.md' %} class="active" {% endif %}><a class="nav-link" href="./useEditController.html"><code>useEditController</code></a></li> | |||
| <li {% if page.path == 'useSaveContext.md' %} class="active" {% endif %}><a class="nav-link" href="./useSaveContext.html"><code>useSaveContext</code></a></li> | |||
| <li {% if page.path == 'useRegisterMutationMiddleware.md' %} class="active" {% endif %}><a class="nav-link" href="./useRegisterMutationMiddleware.html"><code>useRegisterMutationMiddleware</code></a></li> | |||
There was a problem hiding this comment.
you should also update Reference.md
Comment on lines
36
to
48
| const createMiddleware = ( | ||
| resource: string, | ||
| params: CreateParams, | ||
| options: MutateOptions, | ||
| next: CreateMutationFunction | ||
| ) => { | ||
| // Do something before the mutation | ||
|
|
||
| // Call the next middleware | ||
| next(resource, params, options); | ||
|
|
||
| // Do something after the mutation | ||
| } |
There was a problem hiding this comment.
Shouldn't this be written as an async function? 🤔
Suggested change
| const createMiddleware = ( | |
| resource: string, | |
| params: CreateParams, | |
| options: MutateOptions, | |
| next: CreateMutationFunction | |
| ) => { | |
| // Do something before the mutation | |
| // Call the next middleware | |
| next(resource, params, options); | |
| // Do something after the mutation | |
| } | |
| const createMiddleware = async ( | |
| resource: string, | |
| params: CreateParams, | |
| options: MutateOptions, | |
| next: CreateMutationFunction | |
| ) => { | |
| // Do something before the mutation | |
| // Call the next middleware | |
| await next(resource, params, options); | |
| // Do something after the mutation | |
| } |
Comment on lines
68
to
75
| const middlware = (resource, params, options, next) => { | ||
| // Do something before the mutation | ||
|
|
||
| // Call the next middleware | ||
| next(resource, params, options); | ||
|
|
||
| // Do something after the mutation | ||
| } |
slax57
reviewed
Jun 22, 2023
| }); | ||
|
|
||
| const MyImageInput = (props: Omit<ImageInputProps, 'children'>) => { | ||
| const middleware = useCallback(handleImageUpload(props.source), [ |
There was a problem hiding this comment.
new linter warning on this line 😬
fzaninotto
reviewed
Jun 22, 2023
| const middleware = useCallback<Middleware<UseCreateResult[0]>>( | ||
| (resource, params, options, next) => | ||
| handleImageUpload(props.source)(resource, params, options, next), | ||
| [props.source] |
There was a problem hiding this comment.
you will get a warning about handleImageUpload missing in deps
There was a problem hiding this comment.
I no longer see the warning. To me this is good.
slax57
approved these changes
Jun 22, 2023
| const middleware = useCallback<Middleware<UseCreateResult[0]>>( | ||
| (resource, params, options, next) => | ||
| handleImageUpload(props.source)(resource, params, options, next), | ||
| [props.source] |
There was a problem hiding this comment.
I no longer see the warning. To me this is good.
slax57
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.