Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix link to German translation package #9028

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

tommylenz
Copy link
Contributor

The packages previously provided are either no longer maintained or not obtainable anymore. We have created a package providing both formal ("Sie") as well as informal ("du") translation, so that the user can choose what fits best. We are committed to keep the package up-to-date.

The packages previously provided are either no longer maintained or not obtainable anymore. We have created a package providing both formal ("Sie") as well as informal ("du") translation, so that the user can choose what fits best. We are committed to keep the package up-to-date.
@@ -23,7 +23,7 @@ You can find translation packages for the following languages:
- Farsi (`fa`): [hamidfzm/ra-language-farsi](https://github.com/hamidfzm/ra-language-farsi)
- Finnish (`fi`): [aikain/ra-language-finnish](https://github.com/aikain/ra-language-finnish)
- French (`fr`): [marmelab/ra-language-french](https://github.com/marmelab/react-admin/tree/master/packages/ra-language-french)
- German (`de`): [greenbananaCH/ra-language-german](https://github.com/greenbananaCH/ra-language-german) (tree translation: [straurob/ra-tree-language-german](https://github.com/straurob/ra-tree-language-german))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the (translation) at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not only (translation) but (formal and informal translation packages available), the (translation) is only what git keeps from the previous version.
The package exports both formalGermanMessages as well as informalGermanMessages, since German uses different words for those forms, hence the explanation in the brackets. But feel free to remove it it you don't think it's needed.

@fzaninotto fzaninotto merged commit 1aa8691 into marmelab:master Jun 20, 2023
@fzaninotto
Copy link
Member

Understood, thanks for the update!

@fzaninotto fzaninotto added this to the 4.11.4 milestone Jun 20, 2023
@fzaninotto fzaninotto changed the title [RFR] Add maintained ra-language-german [Doc] Fix link to German translation package Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants