Fix linter warnings #8978
Merged
Fix linter warnings #8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Jun 6, 2023
There was a problem hiding this comment.
There are still other unchanged files with linter warnings (see https://github.com/marmelab/react-admin/pull/8978/files). Why not fix them in the same PR?
|
I just hadn't seen them in previous builds... They should now be fixed. |
|
Due to an update in one of our rules, there are TONS of linter warnings. This PR reduces them to 153, down from 503 on |
slax57
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See existing warnings: https://github.com/marmelab/react-admin/pull/8970/files