Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix video playback on iOS #8922

Merged
merged 7 commits into from
May 22, 2023
Merged

[Doc] Fix video playback on iOS #8922

merged 7 commits into from
May 22, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented May 17, 2023

Problem

#8767 turned all GIF files into WebM files (to reduce assets size), but VP9 WebM is not yet supported on iOS Safari.

Solution

Leverage the <video> tag supporting multiple <source> with different types, and also encode all videos in mp4 (with H.265 HVEC codec, including the hvc1 tag for better compatibility with Apple software).

Misc

This PR also

  • Adds back the GIF files to the repo, as it broke some other websites still referencing them
  • Fixes the video maxWidth on mobile
  • Sets the playsinline attribute on all videos to avoid opening the video fullscreen on mobile devices (which would not fit well with autoplay)
  • Makes it easier to test on real mobile hadware with the --host 0.0.0.0 option to jekyll by default

@slax57 slax57 added the RFR Ready For Review label May 17, 2023
@fzaninotto fzaninotto merged commit 28b11b2 into master May 22, 2023
@fzaninotto fzaninotto deleted the webm-to-mp4 branch May 22, 2023 07:25
@fzaninotto fzaninotto added this to the 4.10.4 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants