Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty <ImageField> does not apply sx prop #8850

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

RoBYCoNTe
Copy link
Contributor

If you have many menu items, navigating between them can produce temporary invalid records with empty sourceValue, in this case sometimes we received this error valid value for prop sx on

tag related to the usage of ImageField with specification of sx prop.

To avoid this we replaced standard div with Typography that can accept sx without problems.

@fzaninotto fzaninotto merged commit 2d7cd08 into marmelab:master Apr 23, 2023
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.9.4 milestone Apr 23, 2023
@fzaninotto fzaninotto changed the title fix: valid value for prop sx on <div> tag using ImageField Fix empty <ImageField> does not apply sx prop Apr 23, 2023
@fzaninotto fzaninotto added the fix label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants